Skip to content

[core] test: Add explicit messages when a template fails its validation#2937

Merged
cbentejac merged 1 commit intodevelopfrom
dev/clearMessagesCheckTemplates
Jan 21, 2026
Merged

[core] test: Add explicit messages when a template fails its validation#2937
cbentejac merged 1 commit intodevelopfrom
dev/clearMessagesCheckTemplates

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This PR adds explicit messages that explain why the test that checks whether a template is valid has failed. Prior to it, only compatibility issues were clearly explained.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.91%. Comparing base (f7a48c9) to head (78033ab).
⚠️ Report is 55 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2937   +/-   ##
========================================
  Coverage    78.91%   78.91%           
========================================
  Files           59       59           
  Lines         8305     8305           
========================================
  Hits          6554     6554           
  Misses        1751     1751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the error reporting in the checkTemplateVersions function by adding explicit error messages for three validation failure scenarios. Previously, only compatibility issues had clear error messages, while other validation failures returned False without explanation.

  • Added informative print statements for invalid graph, non-template files, and unknown node types
  • Updated the compatibility issue error message for consistency in formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cbentejac cbentejac force-pushed the dev/clearMessagesCheckTemplates branch from 698caf3 to 78033ab Compare January 12, 2026 11:01
@cbentejac cbentejac merged commit 35e0e38 into develop Jan 21, 2026
4 checks passed
@cbentejac cbentejac deleted the dev/clearMessagesCheckTemplates branch January 21, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants