Skip to content

[core] test: Add explicit messages when a template fails its validation #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[core] test: Add explicit messages when a template fails its validation #2937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion meshroom/core/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,19 @@ def checkTemplateVersions(path: str, nodesAlreadyLoaded: bool = False) -> bool:
try:
graphData = fileData.get(GraphIO.Keys.Graph, fileData)
if not isinstance(graphData, dict):
print(f"File '{path}' does not contain a valid graph.")
return False

header = fileData.get(GraphIO.Keys.Header, {})
if not header.get("template", False):
print(f"File '{path}' is not a valid template.")
return False
nodesVersions = header.get(GraphIO.Keys.NodesVersions, {})

for _, nodeData in graphData.items():
nodeType = nodeData["nodeType"]
if not meshroom.core.pluginManager.isRegistered(nodeType):
print(f"'{nodeType}' in '{path}' is an unknown type.")
return False

nodeDesc = meshroom.core.pluginManager.getRegisteredNodePlugin(nodeType).nodeDescriptor
Expand All @@ -53,7 +56,7 @@ def checkTemplateVersions(path: str, nodesAlreadyLoaded: bool = False) -> bool:
break

if compatibilityIssue is not None:
print(f"{compatibilityIssue} in {path} for node {nodeType}")
print(f"{compatibilityIssue} in '{path}' for node '{nodeType}'.")
return False

return True
Expand Down
Loading