[core] test: Add explicit messages when a template fails its validation #2937
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
requested review from
CedricThebault,
fabiencastan and
servantftransperfect
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2937 +/- ##
========================================
Coverage 80.88% 80.88%
========================================
Files 59 59
Lines 7857 7857
========================================
Hits 6355 6355
Misses 1502 1502 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error reporting in the checkTemplateVersions function by adding explicit error messages for three validation failure scenarios. Previously, only compatibility issues had clear error messages, while other validation failures returned False without explanation.
- Added informative print statements for invalid graph, non-template files, and unknown node types
- Updated the compatibility issue error message for consistency in formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds explicit messages that explain why the test that checks whether a template is valid has failed. Prior to it, only compatibility issues were clearly explained.