Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Dec 9, 2025

Description

This pull request introduces a small but important improvement to the positioning logic for node action headers in the NodeActions.qml file. The update ensures that headers are always displayed within the visible screen area by preventing them from being positioned off-screen.

  • Prevented node action headers from being positioned with negative x or y coordinates, ensuring headers always remain within the visible screen area.

nodeactions_position

@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Dec 9, 2025
@cbentejac cbentejac self-assigned this Dec 9, 2025
@cbentejac cbentejac changed the title [Controls] NodeActions: Keep the NodeActions button visible on the screen when the selected node moves in or out of the Graph Editor's view [Controls] NodeActions: Keep the buttons visible on the screen when the selected node moves in or out of the Graph Editor's view Dec 9, 2025
@cbentejac cbentejac changed the title [Controls] NodeActions: Keep the buttons visible on the screen when the selected node moves in or out of the Graph Editor's view [Controls] NodeActions: Keep the buttons visible on the screen when the selected node moves out of the Graph Editor's view Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.82%. Comparing base (73a9715) to head (c2ca42a).
⚠️ Report is 37 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2952      +/-   ##
===========================================
- Coverage    80.88%   80.82%   -0.06%     
===========================================
  Files           59       59              
  Lines         7857     7844      -13     
===========================================
- Hits          6355     6340      -15     
- Misses        1502     1504       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice merged commit 09bae1d into develop Dec 9, 2025
4 checks passed
@Alxiice Alxiice deleted the dev/nodeActionsPosition branch December 9, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants