Conversation
and moving uninit in Pipe fix #70
simogasp
commented
Feb 4, 2020
fabiencastan
reviewed
Feb 5, 2020
fabiencastan
reviewed
Feb 5, 2020
simogasp
changed the title
griwodz
reviewed
Feb 21, 2020
griwodz
reviewed
Feb 21, 2020
simogasp
added a commit
to alicevision/AliceVision
that referenced
this pull request
Jun 9, 2020
fixes a bug appearing after alicevision/popsift/pull/71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #70, it introduces a state attribute
_isInitin the classPopSiftso that theuninit()method to release the resources can be called explicitly or in the destructor of the class at the end of the object scope.the
uninit()method is also replicated inside the classPipeto release the relevant resources.Incidentally, using
nullptrinstead of 0closes #70