Remove boost from core popsift library#81
Merged
simogasp merged 16 commits intoalicevision:developfrom Apr 20, 2020
andrew-hardin:feature/remove-boost-from-core
Merged
Remove boost from core popsift library#81simogasp merged 16 commits intoalicevision:developfrom andrew-hardin:feature/remove-boost-from-core
simogasp merged 16 commits intoalicevision:developfrom
andrew-hardin:feature/remove-boost-from-core
Conversation
simogasp
requested changes
Apr 10, 2020
Member
simogasp
left a comment
There was a problem hiding this comment.
Hi thank you very much for your contribution, it is really cool if we can just use std library.
I have just few minor remarks.
Thanks!
simogasp
reviewed
Apr 14, 2020
Member
|
@griwodz is it ok for you the replacement of boost::sync_queue with the new smaller in-house class? |
griwodz
approved these changes
Apr 20, 2020
Member
griwodz
left a comment
There was a problem hiding this comment.
These changes for work for me, and they are an improvement. They remove the mix of std::future and boost::thread that was in the code before.
simogasp
approved these changes
Apr 20, 2020
simogasp
approved these changes
Apr 20, 2020
Member
|
Thanks @andrew-hardin for make it simpler! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR strips the boost dependency from the core popsift library. This don't alter the existing code's behavior, and the changes only make use of C++11 features. Here's the list of replaced components:
boost::threadwas replaced bystd::thread.boost::sync_queuewas replaced by a new class calledpopsift::SyncQueue. I'll admit that this doesn't have feature parity with boost, but it does include all the required methods:push(),pull(), andempty().The value of this PR (at least for me) is that it shrinks the required prerequisites for the
popsiftlibrary - it only depends on the CUDA toolkit. This makes the library more atomic, and it adds support for RHEL/CentOS 7 whose official packages are stuck at Boost 1.53.Thank you for considering these changes.