Skip to content

Remove boost from core popsift library #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simogasp merged 16 commits into from
Apr 20, 2020
Merged

Remove boost from core popsift library #81

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0aa91c5
Add a basic sync_queue class.
andrew-hardin Apr 10, 2020
e979663
Replace boost::sync_queue and boost::thread with SyncQueue and std::t…
andrew-hardin Apr 10, 2020
6fc334e
Isolate the boost requirements in src/application.
andrew-hardin Apr 10, 2020
2052529
Munge with the README to reflect changes to the boost requirement.
andrew-hardin Apr 10, 2020
6586b54
Remove boost link/include from popsift.
andrew-hardin Apr 10, 2020
3a58df9
Ignore the reference.tgz that's created by a test.
andrew-hardin Apr 10, 2020
3b469ca
Also link to the threads library.
andrew-hardin Apr 10, 2020
1793247
Add the boost system component; reintroduce win32 condition.
andrew-hardin Apr 10, 2020
f88f56d
Add doxygen comments to SyncQueue.
andrew-hardin Apr 10, 2020
f73fd9f
Move find(threads) to root list; use modern threads target.
andrew-hardin Apr 10, 2020
7a40eb3
Move boost static libs option down to application.
andrew-hardin Apr 10, 2020
54a68ec
Remove boost from the popsift package; add threads.
andrew-hardin Apr 10, 2020
3c420e5
Remove obsolete(?) win32 boost instructions.
andrew-hardin Apr 10, 2020
f763f12
Find threads when loading the config if it hasn't been loaded yet.
andrew-hardin Apr 10, 2020
deab76b
Merge branch 'develop' into feature/remove-boost-from-core
andrew-hardin Apr 14, 2020
249bbca
Replace find_package with find_dependency.
andrew-hardin Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/cmake/Config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@
#
################################################################################


@PACKAGE_INIT@

if(NOT TARGET Threads::Threads)
find_package(Threads REQUIRED)
endif()
Comment thread
simogasp marked this conversation as resolved.
Outdated

include("${CMAKE_CURRENT_LIST_DIR}/@targets_export_name@.cmake")
check_required_components("@PROJECT_NAME@")