[docker] update cmake and split docker in 2 parts#87
Merged
fabiencastan merged 6 commits intodevelopfrom May 17, 2020
Merged
Conversation
simogasp
force-pushed
the
docker/updateCmake
branch
from
f438ac6 to
44b3d43
Compare
fabiencastan
changed the title
| FROM nvidia/cuda:$CUDA_TAG | ||
| ARG CUDA_TAG=10.2 | ||
| ARG OS_TAG=18.04 | ||
| FROM alicevision/popsift:deps-cuda${CUDA_TAG}-ubuntu${OS_TAG} |
Member
There was a problem hiding this comment.
To be consistent with AliceVision:
alicevision/popsift-deps:cuda${CUDA_TAG}-ubuntu${OS_TAG}
Or should we change on the other side?
Member
Author
There was a problem hiding this comment.
ah i didn't see that, I was just following Nvidia pattern nvidia/cuda:${CUDA_TAG}-devel-ubuntu${OS_TAG}
Member
Author
There was a problem hiding this comment.
ah no I thought u were referring to the - instead of _.
I put it like that because I thought on docker hub the image needs to have the same name as the repository hosting it.
fabiencastan
approved these changes
May 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docker file
Dockerfile_depsto build a base image with the dependencies (to be used eg for CI) and the actual image