-
Notifications
You must be signed in to change notification settings - Fork 124
[docker] update cmake and split docker in 2 parts #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b584a12
Update Dockerfile
simogasp d37302c
[doc] changelog
simogasp b8df673
[docker] do not use cd
simogasp bdc6baa
[docker] split deps and image
simogasp 44b3d43
[docker] fix nproc
simogasp 806fd95
[docker] switch popsift-deps
simogasp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| ARG CUDA_TAG=10.2 | ||
| ARG OS_TAG=18.04 | ||
| FROM nvidia/cuda:${CUDA_TAG}-devel-ubuntu${OS_TAG} | ||
| LABEL maintainer="AliceVision Team alicevision@googlegroups.com" | ||
|
|
||
| # use CUDA_TAG to select the image version to use | ||
| # see https://hub.docker.com/r/nvidia/cuda/ | ||
| # | ||
| # For example, to create a ubuntu 16.04 with cuda 8.0 for development, use | ||
| # docker build --build-arg CUDA_TAG=8.0 --tag alicevision/popsift:deps-cuda${CUDA_TAG}-ubuntu${OS_TAG} . | ||
| # | ||
| # then execute with nvidia docker (https://github.com/nvidia/nvidia-docker/wiki/Installation-(version-2.0)) | ||
| # docker run -it --runtime=nvidia popsift_deps | ||
|
|
||
|
|
||
| # OS/Version (FILE): cat /etc/issue.net | ||
| # Cuda version (ENV): $CUDA_VERSION | ||
|
|
||
| # System update | ||
| RUN apt-get clean && apt-get update && apt-get install -y --no-install-recommends\ | ||
| build-essential \ | ||
| wget \ | ||
| unzip \ | ||
| libtool \ | ||
| automake \ | ||
| libssl-dev \ | ||
| libjpeg-turbo8-dev \ | ||
| libdevil-dev \ | ||
| libboost-filesystem-dev \ | ||
| libboost-system-dev \ | ||
| libboost-program-options-dev \ | ||
| libboost-thread-dev \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Manually install cmake | ||
| WORKDIR /tmp/cmake | ||
| ENV CMAKE_VERSION=3.17 | ||
| ENV CMAKE_VERSION_FULL=${CMAKE_VERSION}.2 | ||
| RUN wget https://cmake.org/files/v3.17/cmake-${CMAKE_VERSION_FULL}.tar.gz && \ | ||
| tar zxvf cmake-${CMAKE_VERSION_FULL}.tar.gz && \ | ||
| cd cmake-${CMAKE_VERSION_FULL} && \ | ||
| ./bootstrap --prefix=/usr/local -- -DCMAKE_BUILD_TYPE:STRING=Release -DCMAKE_USE_OPENSSL:BOOL=ON && \ | ||
| make -j$(nproc) install && \ | ||
| cd /tmp && \ | ||
| rm -rf cmake |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with AliceVision:
alicevision/popsift-deps:cuda${CUDA_TAG}-ubuntu${OS_TAG}Or should we change on the other side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i didn't see that, I was just following Nvidia pattern
nvidia/cuda:${CUDA_TAG}-devel-ubuntu${OS_TAG}Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no I thought u were referring to the
-instead of_.I put it like that because I thought on docker hub the image needs to have the same name as the repository hosting it.