Skip to content

mlspaces to lerobot script#52

Open
omarrayyann wants to merge 2 commits intomainfrom
lerobot
Open

mlspaces to lerobot script#52
omarrayyann wants to merge 2 commits intomainfrom
lerobot

Conversation

@omarrayyann
Copy link
Copy Markdown
Collaborator

No description provided.

@omarrayyann omarrayyann requested a review from BlGene April 21, 2026 02:06
Comment on lines +49 to +50
quat_xyzw = np.concatenate([pose7[..., 4:7], pose7[..., 3:4]], axis=-1)
rotmat = Rotation.from_quat(quat_xyzw).as_matrix()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can just do rotmat = Rotation.from_quat(pose7[..., 3:], scalar_first=True), which is a bit clearer


dataset = LeRobotDataset.create(
repo_id=args.repo_id,
fps=POLICY_FPS,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably read this from the data instead of hardcoding


decord.bridge.set_bridge("native")

MLSPACES_GRIPPER_MAX_POS = 0.824033
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add documentation that says this is for the droid data? i.e. would require modification for the rby1 data

@@ -0,0 +1,513 @@
"""Download and extract molmobot-data.
Copy link
Copy Markdown
Member

@abhaybd abhaybd Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this to be more descriptive, like bulk_download_mb_data.py or something? just so it's clear what data this is for.


```bash
DATA=./mbdata/FrankaPickOmniCamConfig/part0/train
python scripts/repair_video_paths.py "$DATA"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary - is it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is part of the instructions in hugging face

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we should probably amend that then, the video paths have already been repaired before uploading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants