Closed
Conversation
pjreddie
reviewed
Oct 23, 2025
pjreddie
reviewed
Oct 23, 2025
Hgherzog
commented
Oct 23, 2025
| ) -> set[tuple[str, int]]: | ||
| """Randomly select which bandsets to decode.""" | ||
| min_decoded, max_decoded = min_max_decode | ||
| if self.allow_encoding_decoding_same_bandset: |
Collaborator
Author
There was a problem hiding this comment.
I think it is clearer to randomly select in both cases then to always take all of the other as we were doing before. If we want an always decode all option we should have that seperately or you just set min and max decoded bandsets to be very high.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully cleaning up the confusing masking code so that it is more readable.