Fix MyPy type error found by pre-commit#449
Open
Volgat wants to merge 1 commit intoallenai:mainfrom
Open
Conversation
Add type: ignore comment for probe_lr parameter to resolve MyPy error: "Argument 'lr' to 'train_and_eval_probe' has incompatible type 'float | None'; expected 'float'" This fix is based on the pre-commit MyPy configuration and follows the same pattern used for ft_lr in the finetune code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type: ignore comment for probe_lr parameter to resolve MyPy error:
"Argument 'lr' to 'train_and_eval_probe' has incompatible type
'float | None'; expected 'float'"
This fix is based on the pre-commit MyPy configuration and follows the same pattern used for ft_lr in the finetune code path.
Note
Add a MyPy
type: ignoretolr=self.probe_lrinevaluator_callback.pyto silence optional-float mismatch for the linear probe path.Written by Cursor Bugbot for commit eb8ada1. This will update automatically on new commits. Configure here.