Fix WorldCereal data by using SINGLE_COMPOSITE and setting correct NODATA#507
Open
Fix WorldCereal data by using SINGLE_COMPOSITE and setting correct NODATA#507
Conversation
…DATA. WorldCereal consists of overlapping GeoTIFFs, but only one of the GeoTIFFs will be valid (not NODATA) at any given location. Previously, this means that matching may pick the wrong GeoTIFF since it is just arbitrarily selecting one that intersects the window. SINGLE_COMPOSITE will put all intersecting GeoTIFFs into the item group, and FIRST_VALID compositing method (along with setting correct nodata value for the materialization) ensures we handle it correctly. This seems to increase the number of tiles with non-zero WorldCereal data by about 20%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorldCereal consists of overlapping GeoTIFFs, but only one of the GeoTIFFs will be valid (not NODATA) at any given location. Previously, this means that matching may pick the wrong GeoTIFF since it is just arbitrarily selecting one that intersects the window. SINGLE_COMPOSITE will put all intersecting GeoTIFFs into the item group, and FIRST_VALID compositing method (along with setting correct nodata value for the materialization) ensures we handle it correctly.
This seems to increase the number of tiles with non-zero WorldCereal data by about 20%.
The change is a simple config change, but the rslearn_to_olmoearth scripts are also updated to latest version of rslearn (where RasterFormat returns RasterArray instead of numpy array).