rslearn task ingestion: verbose and tag filtering#538
Open
Conversation
Collaborator
|
@Farbum Can you link an example run of this eval with the base model? |
Contributor
Author
Yes I will do that soon but this PR should be independent from any task, it is just refining the conversion logic |
Hgherzog
approved these changes
Apr 16, 2026
Collaborator
Hgherzog
left a comment
Hgherzog
left a comment
There was a problem hiding this comment.
LGTM, probs best to not push the new dataset registry info until the dataset is ready
Farbum
force-pushed
the
hadriens/rslearn_task_ingest
branch
from
c032eed to
5866158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process was silent -> added a bunch of logs / tqdm progress bars to track progress
Provided tags were filtered after copying windows which is not ideal for huge dataset. The windows are now filtered before copying starts.