fix(rpc-types-trace): add 0x prefix to storage keys and values in StructLog#3891
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Apr 15, 2026
Merged
Conversation
…uctLog The opcode tracer spec (ethereum/execution-apis#762) requires storage keys and values to be 0x-prefixed bytes32. The serializer was explicitly stripping the prefix with [2..].
figtracer
changed the title
StructLog
figtracer
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opcode tracer spec requires storage keys and values to be
0x-prefixedbytes32.serialize_string_storage_map_optwas explicitly stripping the0xprefix with&key.as_str()[2..]. This produces bare hex likeef7498a2...instead of the spec-required0xef7498a2....Verified on a live reth archive node — storage now serializes as
"0xef7498a2...": "0x00000000...".