Skip to content

fix(rpc-types-trace): add 0x prefix to storage keys and values in StructLog #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Apr 15, 2026
+3 −4
Merged

fix(rpc-types-trace): add 0x prefix to storage keys and values in StructLog #3891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/rpc-types-trace/src/geth/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ impl From<GethDebugTracingOptions> for GethDebugTracingCallOptions {
}
}

/// Serializes a storage map as a list of key-value pairs _without_ 0x-prefix
/// Serializes a storage map as a list of key-value pairs with 0x-prefix
fn serialize_string_storage_map_opt<S: Serializer>(
storage: &Option<BTreeMap<B256, B256>>,
s: S,
Expand All @@ -793,8 +793,7 @@ fn serialize_string_storage_map_opt<S: Serializer>(
for (key, val) in storage {
let key = format!("{key:?}");
let val = format!("{val:?}");
// skip the 0x prefix
m.serialize_entry(&key.as_str()[2..], &val.as_str()[2..])?;
m.serialize_entry(key.as_str(), val.as_str())?;
}
m.end()
}
Expand Down Expand Up @@ -872,7 +871,7 @@ mod tests {

#[test]
fn test_serialize_storage_map() {
let s = r#"{"pc":3349,"op":"SLOAD","gas":23959,"gasCost":2100,"depth":1,"stack":[],"memory":[],"storage":{"6693dabf5ec7ab1a0d1c5bc58451f85d5e44d504c9ffeb75799bfdb61aa2997a":"0000000000000000000000000000000000000000000000000000000000000000"}}"#;
let s = r#"{"pc":3349,"op":"SLOAD","gas":23959,"gasCost":2100,"depth":1,"stack":[],"memory":[],"storage":{"0x6693dabf5ec7ab1a0d1c5bc58451f85d5e44d504c9ffeb75799bfdb61aa2997a":"0x0000000000000000000000000000000000000000000000000000000000000000"}}"#;
let log: StructLog = serde_json::from_str(s).unwrap();
let val = serde_json::to_value(&log).unwrap();
let input = serde_json::from_str::<serde_json::Value>(s).unwrap();
Expand Down
Loading