Skip to content

fix: ignore prereleases in svm-builds #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grandizzy wants to merge 1 commit into from
Closed

fix: ignore prereleases in svm-builds #178

grandizzy wants to merge 1 commit into from

Conversation

@grandizzy
Copy link
Contributor

@grandizzy grandizzy commented Dec 3, 2025

No description provided.

@grandizzy grandizzy force-pushed the gdzzy/fix-prerelease branch from 5fb6bb1 to ee99800 Compare December 3, 2025 18:31
@RonTuretzky RonTuretzky mentioned this pull request Dec 3, 2025
Merged
3 tasks
mablr
mablr reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@mablr mablr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was working on Foundry PR I also made a patch locally that handles prereleases instead ignoring them.

Here is my working branch if you find this helpful https://github.com/mablr/svm-rs/tree/fix/handle_pre_versions

@grandizzy
Copy link
Contributor Author

grandizzy commented Dec 3, 2025

As I was working on Foundry PR I also made a patch locally that handles prereleases instead ignoring them.

Here is my working branch if you find this helpful https://github.com/mablr/svm-rs/tree/fix/handle_pre_versions

Nice, much better, can you pls issue a PR? Thanks!

@grandizzy
Copy link
Contributor Author

grandizzy commented Dec 3, 2025

@mablr also can you pls test your PR by using solc_version = 0.8.31-pre.1 and solc_version = 0.8.31 in a foundry.toml / counter project? Thanks!

@mablr
Copy link
Contributor

mablr commented Dec 3, 2025

ok i'll do it

@mablr mablr mentioned this pull request Dec 3, 2025
Merged
@mablr
Copy link
Contributor

mablr commented Dec 4, 2025

@grandizzy #179 is tested and now ready I guess

@grandizzy
Copy link
Contributor Author

grandizzy commented Dec 4, 2025

@mablr thank you!

@grandizzy grandizzy closed this Dec 4, 2025
grandizzy pushed a commit that referenced this pull request Dec 4, 2025
@mablr
fix(svm-builds): handle prerelease solidity versions (#179)
f277539 
closes #177 

superseeds #178

Fixes `Releases::get_checksum()` version matching logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

1 more reviewer

@mablr mablr mablr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grandizzy @mablr