Draft feedback component#6932
Draft
owenatgov wants to merge 14 commits into
Draft
Conversation
📋 StatsNo changes to any distributed file sizes! Action run for 7009a59 |
- implemented full width - played with the spacing
Custom properties cant be used in media queries :(
Contributor
|
Something to consider if this goes to production: Should we be using grid classes or give a custom constraint, and given that it's different between components e.g. cookie banner vs notification banner should we consider a holistic solution? |
Test Feedback component - Move govuk-width-container into root
2 tasks
Contributor
|
Parent issue alphagov/govuk-design-system#5228 is complete, this PR will stay open as we go into testing this component with partners. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of alphagov/govuk-design-system#5227
Component can be found by going to the new confirmation page full page example in the deploy preview.