-
Notifications
You must be signed in to change notification settings - Fork 365
Draft feedback component #6932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
owenatgov
wants to merge
14
commits into
main
Choose a base branch
from
feedback-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft feedback component #6932
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b1c0d81
Draft feedback component
owenatgov f1ab32a
Added phase banner
lewisdarlow-gds b8b2dac
Adding in content to phase banner
lewisdarlow-gds d61b733
Bump Heroku
NickColley cfa8d5b
Make it work better on small screen
hazalarpalikli 82584e7
Add last child selector to last paragraph override
owenatgov 9ce7cfe
Add fallbacks to custom property calls
owenatgov ed29158
Replace phase banner with macro call
owenatgov 62fbeb6
Fix media query
NickColley 375462e
Rename namespace to test-
NickColley f6964af
Move govuk-width-container into root
NickColley 8a32f14
Merge pull request #6969 from alphagov/feedback-component-other-markup
NickColley cbd7043
Add new phase banner text
calvin-lau-sig7 7009a59
Edit call to action text
calvin-lau-sig7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
88 changes: 88 additions & 0 deletions
88
packages/govuk-frontend-review/src/views/full-page-examples/confirmation-page/index.njk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| --- | ||
| title: Application complete | ||
| name: Confirmation page | ||
| scenario: You have reached the end of a service | ||
|
|
||
| notes: | | ||
| We'll write these later | ||
| --- | ||
|
|
||
| {% extends "layouts/full-page-example.njk" %} | ||
|
|
||
| {# {% set mainClasses = "govuk-main-wrapper--l" %} #} | ||
| {# remember to set the title properly #} | ||
| {% from "govuk/components/panel/macro.njk" import govukPanel %} | ||
| {% from "govuk/components/phase-banner/macro.njk" import govukPhaseBanner %} | ||
|
|
||
| {% set pageTitle = example.title %} | ||
| {% block pageTitle %}{{ pageTitle }} - GOV.UK{% endblock %} | ||
|
|
||
| {% block headerEnd %} | ||
| {{ govukPhaseBanner({ | ||
| tag: { | ||
| text: "Alpha" | ||
| }, | ||
| html: 'This is a new service. We’re still working on ways to improve it.' | ||
| }) }} | ||
| {% endblock %} | ||
|
|
||
| {% block content %} | ||
| <div class="govuk-grid-row"> | ||
| <div class="govuk-grid-column-two-thirds"> | ||
| {{ govukPanel({ | ||
| titleText: pageTitle, | ||
| html: "Your reference number<br><strong>HDJ2123F</strong>" | ||
| }) }} | ||
|
|
||
| <p class="govuk-body">We have sent you a confirmation email.</p> | ||
|
|
||
| <h2 class="govuk-heading-m">What happens next</h2> | ||
|
|
||
| <p class="govuk-body"> | ||
| We’ve sent your application to Hackney Electoral Register Office. | ||
| </p> | ||
| <p class="govuk-body"> | ||
| They will contact you either to confirm your registration, or to ask for more information. | ||
| </p> | ||
| </div> | ||
| </div> | ||
| {% endblock %} | ||
|
|
||
| {% block footerStart %} | ||
| <div class="test-feedback govuk-width-container"> | ||
| <div class="govuk-grid-row"> | ||
| <div class="govuk-grid-column-two-thirds"> | ||
| <h2 class="govuk-heading-m">Help us improve this service</h2> | ||
| <p class="govuk-body">Tell us about your experience using this service. You’ll help us make improvements by <a href="#" class="govuk-link">giving us your feedback</a>.</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <style> | ||
| .test-feedback { | ||
| box-sizing: border-box; | ||
| border-top: 1px solid var(--govuk-brand-colour, #1d70b8); | ||
| padding: 20px 15px 25px; | ||
| background-color: var(--govuk-surface-background-colour, #f4f8fb); | ||
| } | ||
|
|
||
| .test-feedback .govuk-body:last-child { | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| @media (min-width: 40.0625rem) { | ||
| .test-feedback { | ||
| padding-left: 20px; | ||
|
NickColley marked this conversation as resolved.
|
||
| padding-right: 20px; | ||
| } | ||
| } | ||
|
|
||
| @media (max-width: calc(40.0625rem - 1px)) { | ||
| .test-feedback { | ||
| margin-left: 0; | ||
| margin-right: 0; | ||
| } | ||
| } | ||
| </style> | ||
| {% endblock %} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.