Add integration tests simulating libaries including GOV.UK Frontend#7095
Open
romaricpascal wants to merge 3 commits into
Open
Add integration tests simulating libaries including GOV.UK Frontend#7095romaricpascal wants to merge 3 commits into
romaricpascal wants to merge 3 commits into
Conversation
📋 StatsNo changes to any distributed file sizes! Action run for f4c096f |
We need to explicitely import `index.import` because Sass does not load the import only file if using `pkg:` URLs: https://github.com/sass/dart-sass/issues/2771
Adds the library, but tests still need adding
…tend Verify that when configuring the library, the configuration also gets applied to a subsequent library that `@use`s GOV.UK Frontend.
romaricpascal
force-pushed
the
libraries-integration-tests
branch
from
821a565 to
f4c096f
Compare
NickColley
reviewed
May 28, 2026
| @@ -0,0 +1,6 @@ | |||
| @import "pkg:govuk-frontend/index.import"; | |||
Contributor
There was a problem hiding this comment.
I think we spoke about it before sorry but should we also have a case for
@import "pkg:govuk-frontend"; ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests checking that configuration gets applied properly when libraries include GOV.UK Frontend:
@importboth GOV.UK Frontend and the library get appropriately configured by global variables@usethe library gets appropriately affected by configuration ofpkg:govuk-frontend@forwardconfiguring the library appropriately configures both GOV.UK Frontend and a subsequent library that@uses GOV.UK FrontendAs we're recommending to either only
@useor@importall your stylesheets, this PR does not add any tests about mixing@useand@import(we already know this may lead to duplicate output or GOV.UK Frontend getting loaded again with a blank configuration due to how Sass loads files).