-
Notifications
You must be signed in to change notification settings - Fork 366
Add integration tests simulating libaries including GOV.UK Frontend #7095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romaricpascal
wants to merge
3
commits into
main
Choose a base branch
from
libraries-integration-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
59d7690
Add tests simulating including a library that `@import`s GOV.UK Frontend
romaricpascal a40ef71
Add tests simulating including a library that `@use`s GOV.UK Frontend
romaricpascal f4c096f
Add tests simulating including a library that `@forward`s GOV.UK Fron…
romaricpascal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| import { compileSassStringLikeUsers } from './helpers/sass.js' | ||
|
|
||
| describe('libraries', () => { | ||
| describe('if the library `@import`s GOV.UK Frontend', () => { | ||
| describe('without configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| // Sass does not resolve import-only files when using `pkg:` URLs | ||
| // with `@import` so we need to explicitely load `index.import` | ||
| // See: https://github.com/sass/sass/issues/4224 | ||
| const sass = ` | ||
| @import 'pkg:govuk-frontend/index.import'; | ||
| @import 'libraries/with-import/index'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('outputs the CSS of GOV.UK Frontend only once', async () => { | ||
| expect(css.match(/govuk-visually-hidden/)).toHaveLength(1) | ||
| }) | ||
|
|
||
| it('applied the default GOV.UK Frontend configuration to the library', async () => { | ||
| expect(css).toContain( | ||
| '--with-import-colour: var(--govuk-brand-colour, #1d70b8)' | ||
| ) | ||
| expect(css).toContain( | ||
| '--with-import-icon: url("/assets/images/home-icon.svg")' | ||
| ) | ||
| }) | ||
| }) | ||
|
|
||
| describe('with configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| $govuk-functional-colours: (brand: hotpink); | ||
| $govuk-image-url-function: 'images-url'; | ||
|
|
||
| @import 'pkg:@govuk-frontend/helpers/assets-urls'; | ||
| @import 'pkg:govuk-frontend/index.import'; | ||
| @import 'libraries/with-import/index'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('applies configuration to both GOV.UK Frontend and the library', async () => { | ||
| expect(css).toContain('--govuk-brand-colour: hotpink') | ||
| expect(css).toContain( | ||
| '--with-import-colour: var(--govuk-brand-colour, hotpink)' | ||
| ) | ||
| expect(css).toContain('--with-import-icon: url("example.svg")') | ||
| }) | ||
| }) | ||
|
|
||
| describe('without explicitly `@import`ing GOV.UK Frontend', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| $govuk-functional-colours: (brand: hotpink); | ||
| $govuk-image-url-function: 'images-url'; | ||
|
|
||
| @import 'pkg:@govuk-frontend/helpers/assets-urls'; | ||
| @import 'libraries/with-import/index'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('applies configuration to both GOV.UK Frontend and the library', async () => { | ||
| expect(css).toContain('--govuk-brand-colour: hotpink') | ||
| expect(css).toContain( | ||
| '--with-import-colour: var(--govuk-brand-colour, hotpink)' | ||
| ) | ||
| expect(css).toContain('--with-import-icon: url("example.svg")') | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('if the library `@use`s GOV.UK Frontend', () => { | ||
| describe('without configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| @use 'pkg:govuk-frontend'; | ||
| @use 'libraries/with-use'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('outputs the CSS of GOV.UK Frontend only once', async () => { | ||
| expect(css.match(/govuk-visually-hidden/)).toHaveLength(1) | ||
| }) | ||
|
|
||
| it('applied the default GOV.UK Frontend configuration to the library', async () => { | ||
| expect(css).toContain( | ||
| '--with-use-colour: var(--govuk-brand-colour, #1d70b8)' | ||
| ) | ||
| expect(css).toContain( | ||
| '--with-use-icon: url("/assets/images/home-icon.svg")' | ||
| ) | ||
| }) | ||
| }) | ||
|
|
||
| describe('with configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| @use "sass:meta"; | ||
| @use 'pkg:@govuk-frontend/helpers/assets-urls'; | ||
| @use 'pkg:govuk-frontend' with ( | ||
| $govuk-functional-colours: (brand: hotpink), | ||
| $govuk-image-url-function: meta.get-function('images-url', $module: 'assets-urls') | ||
| ); | ||
| @use 'libraries/with-use'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('applies configuration to both GOV.UK Frontend and the library', async () => { | ||
| expect(css).toContain('--govuk-brand-colour: hotpink') | ||
| expect(css).toContain( | ||
| '--with-use-colour: var(--govuk-brand-colour, hotpink)' | ||
| ) | ||
| expect(css).toContain('--with-use-icon: url("example.svg")') | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('if a library `@forward`s GOV.UK Frontend and another `@use`s it', () => { | ||
| describe('without configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| @use 'libraries/with-forward'; | ||
| @use 'libraries/with-use'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('outputs the CSS of GOV.UK Frontend only once', async () => { | ||
| expect(css.match(/govuk-visually-hidden/)).toHaveLength(1) | ||
| }) | ||
|
|
||
| it('applied the default GOV.UK Frontend configuration to both libaries', async () => { | ||
| expect(css).toContain( | ||
| '--with-use-colour: var(--govuk-brand-colour, #1d70b8)' | ||
| ) | ||
| expect(css).toContain( | ||
| '--with-use-icon: url("/assets/images/home-icon.svg")' | ||
| ) | ||
| expect(css).toContain( | ||
| '--with-forward-colour: var(--govuk-brand-colour, #1d70b8)' | ||
| ) | ||
| expect(css).toContain( | ||
| '--with-forward-icon: url("/assets/images/home-icon.svg")' | ||
| ) | ||
| }) | ||
| }) | ||
|
|
||
| describe('with configuration', () => { | ||
| let css | ||
|
|
||
| beforeAll(async () => { | ||
| const sass = ` | ||
| @use "sass:meta"; | ||
| @use 'pkg:@govuk-frontend/helpers/assets-urls'; | ||
| @use 'libraries/with-forward' with ( | ||
| $govuk-functional-colours: (brand: hotpink), | ||
| $govuk-image-url-function: meta.get-function('images-url', $module: 'assets-urls') | ||
| ); | ||
| @use 'libraries/with-use'; | ||
| ` | ||
|
|
||
| css = await compileSassStringLikeUsers(sass) | ||
| }) | ||
|
|
||
| it('applies configuration to both GOV.UK Frontend and the libraries', async () => { | ||
| expect(css).toContain('--govuk-brand-colour: hotpink') | ||
| expect(css).toContain( | ||
| '--with-use-colour: var(--govuk-brand-colour, hotpink)' | ||
| ) | ||
| expect(css).toContain('--with-use-icon: url("example.svg")') | ||
| expect(css).toContain( | ||
| '--with-forward-colour: var(--govuk-brand-colour, hotpink)' | ||
| ) | ||
| expect(css).toContain('--with-forward-icon: url("example.svg")') | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| @forward "pkg:govuk-frontend"; | ||
| @use "pkg:govuk-frontend" as *; | ||
|
|
||
| :root { | ||
| --with-forward-colour: #{govuk-functional-colour("brand")}; | ||
| --with-forward-icon: #{govuk-image-url("home-icon.svg")}; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| @import "pkg:govuk-frontend/index.import"; | ||
|
|
||
| :root { | ||
| --with-import-colour: #{govuk-functional-colour("brand")}; | ||
| --with-import-icon: #{govuk-image-url("home-icon.svg")}; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| @use "pkg:govuk-frontend" as *; | ||
|
|
||
| :root { | ||
| --with-use-colour: #{govuk-functional-colour("brand")}; | ||
| --with-use-icon: #{govuk-image-url("home-icon.svg")}; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we spoke about it before sorry but should we also have a case for
@import "pkg:govuk-frontend";?