fix: set custom invoice number only if available#228
Merged
Conversation
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available.
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where e-invoice validation would fail during draft saves when a custom invoice number is configured but not yet generated. The fix adds a check to ensure the custom invoice number field has a value before using it, falling back to the document name otherwise.
Changes:
- Modified the invoice number assignment logic to check both the field configuration and value availability using the walrus operator
Member
Author
|
@Mergifyio backport version-16-hotfix version-15-hotfix |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available. (cherry picked from commit 7f79976)
mergify Bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available. (cherry picked from commit 7f79976)
barredterra
added a commit
that referenced
this pull request
Feb 17, 2026
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available. (cherry picked from commit 7f79976) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
barredterra
added a commit
that referenced
this pull request
Feb 17, 2026
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available. (cherry picked from commit 7f79976) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom invoice number might not be generated until submission.
For e-invoice validation to pass during previous draft saves, we need to fall back to
doc.nameas long as the custom number is not available.