hdl.ir: for anon fragments derive name from type where possible #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of `Fragment.origins` and `Instance.type` to derive nicer names for anonymous fragments. For non-Instance `Fragment`s without origins we still fall back to the previous `U$<number>` naming. The new names look like `<type_name>$<number>`, where `<number>` is derived from the source location as before. From `Fragment.origins` the outermost (i.e. first) element (which currently should always be an instance of `Elaboratable`, if present) is picked, and from it, its python type `__name__`. Fixes #1525
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 44 44
Lines 11471 11478 +7
Branches 2236 2237 +1
=======================================
+ Hits 10471 10478 +7
Misses 837 837
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
whitequark
requested changes
Dec 20, 2025
Member
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution!
Please add a changelog entry, as this does change the netlist output in an observable way (e.g. it will break every saved .gtkw file).
Contributor
Author
|
Does that change description sound good and is that the right section? |
whitequark
approved these changes
Dec 20, 2025
Merged
via the queue into
amaranth-lang:main
with commit Dec 20, 2025
3a3bf81
20 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of
Fragment.originsandInstance.typeto derive nicer names for anonymous fragments.For non-Instance
Fragments without origins we still fall back to the previousU$<number>naming.The new names look like
<type_name>$<number>, where<number>is derived from the source locationas before.
From
Fragment.originsthe outermost (i.e. first) element (which currently should always be aninstance of
Elaboratable, if present) is picked, and from it, its python type__name__.Fixes #1525