Fix for "Supplied part name is invalid" GW5AST-LV138PG484AC1/I0 #1652
Open
mlapaj wants to merge 2 commits intoamaranth-lang:mainfrom
Open
Fix for "Supplied part name is invalid" GW5AST-LV138PG484AC1/I0 #1652mlapaj wants to merge 2 commits intoamaranth-lang:mainfrom
mlapaj wants to merge 2 commits intoamaranth-lang:mainfrom
Conversation
Fix in part recognision
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
+ Coverage 91.23% 91.28% +0.04%
==========================================
Files 44 44
Lines 11402 11517 +115
Branches 2224 2242 +18
==========================================
+ Hits 10403 10513 +110
- Misses 836 842 +6
+ Partials 163 162 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks, the fix looks reasonable. Please squash the commits and use the following commit message, then I'll merge the PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have bought Tang Mega 138k. It contains GW5AST-LV138PG484AC1/I0 FPGA IC (I have prepared tang_mega_138k board definition and I'd like to contribute it separately).
When compiling blinky example
I see following error:
Traceback (most recent call last):
File "/home/user/Mega138k/1_Blinky/./blinky.py", line 25, in
platform = TangMega138kPlatform(toolchain='Gowin')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/oss-cad-suite/lib/python3.11/site-packages/amaranth/vendor/_gowin.py", line 473, in init
self.parse_part()
File "/oss-cad-suite/lib/python3.11/site-packages/amaranth/vendor/_gowin.py", line 215, in parse_part
raise ValueError("Supplied part name is invalid")
ValueError: Supplied part name is invalid