ci: publish holosoma-inference to PyPI (1/3)#142
Merged
Conversation
cfe28b3 to
7d5bad6
Compare
7d5bad6 to
5354a4a
Compare
kingb
approved these changes
Jul 2, 2026
kingb
left a comment
Contributor
There was a problem hiding this comment.
Approving. Verified: GHA SHA pins resolve correctly (checkout v6.0.2, upload-artifact v7, download-artifact v8), PyPI project names match the per-package workflows, and the tag globs don't collide. Reusable build + OIDC trusted-publishing pattern is sound. One non-blocking follow-up raised separately: confirm the runner's preinstalled uv supports --trusted-publishing always before the first release tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 1 of 3 — publish the holosoma packages to PyPI.
Adds the shared reusable build workflow + the first per-package publisher.
.github/workflows/_build-python-dist.yml— reusable (workflow_call) build:python -m build(sdist +py3-none-anywheel) →twine check→ uploaddistartifact. Driven by the runner's ownpython3in a venv (noactions/setup-python, same as the SDKrelease.yml)..github/workflows/publish-holosoma-inference.yml— triggers on tagholosoma-inference-v*(or manual dispatch = build-only). Publishes via OIDC Trusted Publishing (environment: pypi,id-token: write, no stored tokens).Stack (merge bottom-up):
main; original base PR switching to using pypi sdks #139 already merged)clayros/publish-holosoma-retargeting(ci: publish holosoma-retargeting to PyPI (2/3) #140)clayros/publish-holosoma(ci: publish holosoma (core) to PyPI (3/3) #141)PyPI setup required (owner does this side): register a Trusted Publisher on the
holosoma-inferencePyPI project → repoamazon-far/holosoma, workflowpublish-holosoma-inference.yml, environmentpypi.