Switch from Python aircc to C++ aircc binary#22
Merged
Conversation
Replace the in-process Python aircc.run() call with a subprocess call to the C++ aircc binary shipped in the mlir-air wheel. The C++ binary is a full rewrite using LLVM's CommandLine library and in-process MLIR PassManager, and is the intended replacement for the Python tool. The IR file (asm_air_output.mlir) is already written to disk before this point, so the change is straightforward: pass the file path as a positional argument to the C++ binary with the same CLI options. Verified: all 14 non-skipped examples pass on NPU2 (Strix/AIE2P). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aircc.run()call with asubprocess.check_call()to the C++airccbinary shipped in the mlir-air wheelmlir_air/bin/aircc) is a full rewrite using LLVM's CommandLine library and in-process MLIR PassManager, intended to replace the Pythonaircc.pyasm_air_output.mlir) is already written to disk at this point in the pipeline, so the change is a straightforward swapTest plan
🤖 Generated with Claude Code