Remove vestigial boost dependencies#38
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes now-unneeded Boost linkage and CI dependencies after mlir-aie’s test_utils library migration away from Boost (to cxxopts and std::filesystem), simplifying both the JIT build path and the CI image.
Changes:
- Drop
-lboost_program_optionsand-lboost_filesystemfrom the xclbin-mode launcher compilation flags. - Remove Boost-related dev packages from the CI Docker image.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ci/docker-based/Dockerfile |
Removes Boost dev packages from the CI container build dependencies. |
amd_triton_npu/backend/driver.py |
Removes Boost link flags from the xclbin-mode JIT compilation path (keeps -ltest_utils). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The test_utils library in mlir-aie was migrated from boost (boost_program_options, boost_filesystem) to cxxopts and std::filesystem. The boost link flags in the JIT compilation path and boost packages in the CI Dockerfile are no longer needed. Verified: libtest_utils.a contains zero boost symbols. Clean build and 12/12 NPU1 e2e tests pass without boost. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| f"-L{os.path.join(aie_test_utils_dir, 'lib')}", | ||
| "-lboost_program_options", | ||
| "-lboost_filesystem", | ||
| "-ltest_utils", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
You're right. I confirmed that the Windows mlir-aie wheel ships headers in test_lib/include/ but the test_lib/lib/ directory (containing libtest_utils.a) is missing entirely. I'll get it fixed in mlir-aie.
There was a problem hiding this comment.
PR created on mlir-aie: Xilinx/mlir-aie#3024
There was a problem hiding this comment.
Great thank you. I just figured it was easier to point it out here.
Summary
-lboost_program_optionsand-lboost_filesystemlink flags from the xclbin-mode JIT compilation path indriver.pylibboost-dev,libboost-filesystem-dev, andlibboost-program-options-devfrom the CI DockerfileThe
test_utilslibrary in mlir-aie was migrated from boost tocxxoptsandstd::filesystem. Confirmed vianm:libtest_utils.acontains zero boost symbols. These link flags and CI packages are no longer needed.Test plan
rm -rf third_party/triton/build && ninja -Cbuild)python scripts/run_tests.py --device aie2)weighted_rms_norm(unrelated mlir-air pipeline error)layernorm,load_2d_block,multi_drivers)🤖 Generated with Claude Code