Skip to content

Remove vestigial boost dependencies #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwei-xilinx merged 1 commit into from
Apr 8, 2026
Merged

Remove vestigial boost dependencies #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions amd_triton_npu/backend/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,8 +1243,6 @@ def launch(
compile_flags += [
f"-I{os.path.join(aie_test_utils_dir, 'include')}",
f"-L{os.path.join(aie_test_utils_dir, 'lib')}",
"-lboost_program_options",
"-lboost_filesystem",
"-ltest_utils",

This comment was marked as resolved.

Sign in to view

@erwei-xilinx erwei-xilinx Apr 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I confirmed that the Windows mlir-aie wheel ships headers in test_lib/include/ but the test_lib/lib/ directory (containing libtest_utils.a) is missing entirely. I'll get it fixed in mlir-aie.

@erwei-xilinx erwei-xilinx Apr 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR created on mlir-aie: Xilinx/mlir-aie#3024

@astrelsky astrelsky Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you. I just figured it was easier to point it out here.

]
compile_flags += ["-o", so_path]
Expand Down
2 changes: 1 addition & 1 deletion ci/docker-based/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
# MLIR-AIE build requirements
build-essential ninja-build cmake python3 python3-dev python3.12-venv python3-pip unzip \
libssl-dev libboost-dev libboost-filesystem-dev libboost-program-options-dev uuid-dev \
libssl-dev uuid-dev \
# Required by MHA kernel
llvm-18 \
# Clang toolchain for Triton build
Expand Down
Loading