Skip to content

chore(test): upgrade jest to v30#373

Merged
guym4c merged 2 commits into
americanexpress:mainfrom
webbugt:feat/jest-30
Sep 23, 2025
Merged

chore(test): upgrade jest to v30#373
guym4c merged 2 commits into
americanexpress:mainfrom
webbugt:feat/jest-30

Conversation

@webbugt

@webbugt webbugt commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Description

Basically update the function usage to work with jest 30.

The changes are rather trivial, used Copilot with official migration guide to scan the repo for incorrect function calls and fix them. Manually checked and validated all changes.

Motivation and Context

We needed this package in Jest 30 testing setup, downgrading was not an option
Fixes #371, although might break compatibility with older versions

How Has This Been Tested?

Tests in the repository are all passing and only modifications made we're the updated function calls

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • [ x ] Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • [ x ] My changes are in sync with the code style of this project.
  • [ x ] There aren't any other open Pull Requests for the same issue/update.
  • [ x ] These changes should be applied to a maintenance branch.
  • [ x ] I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

Might break compatibility with Jest <30.

@CLAassistant

CLAassistant commented Aug 14, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to keep this instruction file in the repo since it has been used and will unlikely be used again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I will remove it

@guym4c guym4c changed the title WIP: Upgrade jest to v30 chore(test): upgrade jest to v30 Sep 23, 2025
@guym4c guym4c merged commit d560952 into americanexpress:main Sep 23, 2025
10 checks passed
@eddienubes

Copy link
Copy Markdown

@code-forger @guym4c Hi guys! I see this PR's been sitting done in main for a while, could you please release the new version?

@oneamexbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for jest 30

7 participants