Add optional Ion-SFU support and integration test coverage#232
Draft
zohrehasadi00 wants to merge 13 commits intomainfrom
Draft
Add optional Ion-SFU support and integration test coverage#232zohrehasadi00 wants to merge 13 commits intomainfrom
zohrehasadi00 wants to merge 13 commits intomainfrom
Conversation
… Detection interface Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
… optional labelText Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
…orporating optional labelText Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
…n options Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
…dling and track management Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
Signed-off-by: Zohreh Asadi <z.asadi@campus.tu-berlin.de>
fhilgers
requested changes
Jan 13, 2026
Collaborator
fhilgers
left a comment
fhilgers
left a comment
There was a problem hiding this comment.
I cannot get it to work:
Steps to reproduce:
- Start ion sfu:
docker run -p 7000:7000 -p 5000-5200:5000-5200/udp pionwebrtc/ion-sfu:latest-jsonrpc - Start Frontend:
VITE_WEBRTC_MODE=ion-sfu VITE_SFU_URL=ws://localhost:7000/ws make run-frontend-local - Start Analyzer:
WEBRTC_MODE=ion-sfu SFU_SIGNALING_URL=ws://localhost:7000/ws make run-analyzer-local - Start Webcam:
WEBRTC_MODE=ion-sfu SFU_SIGNALING_URL=ws://localhost:7000/ws make run-streamer-local
I can see the video in the frontend but there are no detections happening, e.g. no overlay drawn and also the analyzer is not logging anything.
Signed-off-by: Zohreh Asadi <zohrehasadi2018@yahoo.com>
Contributor
Author
|
@fhilgers could you check it out again? |
Collaborator
|
@zohrehasadi00 I tried it out again and sadly the same happens. I can try to look at the code and find a fix until the end of the week, I won't be able to fix it until tomorrow. If some of the other devs wants to help you test and fix it that would be even better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFU in both back- and frontend. I wrote a test for it too
Tag the people who should review this:
@Tenebrae311 @fhilgers @Paul2607 @saribx @ChristophMantsch @BenediktZinn @anuunchin