Fix local image tag resolution for monorepo tags#18
Merged
Conversation
The "Determine local image tag" step used `git describe --tag --always --dirty` without a match filter. For v1.13.5 the commit carries both `v1.13.5` and `pkg/machinery/v1.13.5` tags, and describe resolved to the latter — whose slashes are an invalid Docker reference and don't match the image Talos actually pushes. Talos's own Makefile tags images with `git describe ... --match v[0-9]\*`, so add the same filter here to keep the resolved tag in sync with the pushed image (e.g. v1.13.5-dirty). Fixes #17 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause (Fixes #17)
The v1.13.5 build failed at the "Push images to GHCR with project naming" step:
The
Determine local image tagstep rangit describe --tag --always --dirtywithout a--matchfilter. The v1.13.5 commit carries both av1.13.5and apkg/machinery/v1.13.5tag, and describe resolved to the latter. Its slashes make it an invalid Docker reference, and it also doesn't match the tag Talos actually pushes (v1.13.5-dirty).Verification:
Fix
Add the same
--match 'v[0-9]*'filter that Talos's own Makefile uses (TAG := git describe --tag --always --dirty --match v[0-9]\*), so the resolved local tag stays in sync with the pushed image.Impact
.github/workflows/build.yml(patches and scripts untouched).--match 'v[0-9]*'mirrors Talos's canonical logic, so it remains backward compatible across other versions.🤖 Generated with Claude Code