Skip to content

Fix local image tag resolution for monorepo tags #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoyrtil merged 1 commit into from
Jun 27, 2026
Merged

Fix local image tag resolution for monorepo tags #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,13 @@ jobs:
if: steps.check-talos.outputs.exists == 'false'
id: local-tag
run: |
# Talos appends -dirty when source is modified
# Match Talos's own Makefile tag logic (TAG := git describe --tag
# --always --dirty --match v[0-9]\*). Without --match, describe can
# resolve to a monorepo tag like pkg/machinery/v1.13.5, whose slashes
# are an invalid Docker reference and don't match the pushed image.
# Talos appends -dirty when source is modified.
cd /tmp/talos
TAG=$(git describe --tag --always --dirty 2>/dev/null || echo "${{ inputs.talos_version }}-dirty")
TAG=$(git describe --tag --always --dirty --match 'v[0-9]*' 2>/dev/null || echo "${{ inputs.talos_version }}-dirty")
echo "tag=${TAG}" >> "$GITHUB_OUTPUT"
echo "Local image tag: ${TAG}"

Expand Down
Loading