Skip to content

change SOVERSION to use MAJOR.MINOR format instead of MAJOR.MINOR.PATCH #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

change SOVERSION to use MAJOR.MINOR format instead of MAJOR.MINOR.PATCH #186

merged 2 commits into from
Jul 28, 2025

Conversation

@michaeldsmith
Copy link
Collaborator

@michaeldsmith michaeldsmith commented Jul 28, 2025

@michaeldsmith michaeldsmith mentioned this pull request Jul 28, 2025
Closed
@michaeldsmith
Copy link
Collaborator Author

michaeldsmith commented Jul 28, 2025 •
edited
Loading

@paolostivanin @LecrisUT please review this PR

LecrisUT
LecrisUT suggested changes Jul 28, 2025
View reviewed changes
CMakeLists.txt Outdated
set(CTL_VERSION_MINOR 5)
set(CTL_VERSION_PATCH 3)
set(CTL_VERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}.${CTL_VERSION_PATCH}")
project(CTL VERSION ${CTL_VERSION})
Copy link

@LecrisUT LecrisUT Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this part. The CTL_VERSION_* are automatically created

@michaeldsmith michaeldsmith merged commit cbb1d2b into ampas:master Jul 28, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LecrisUT LecrisUT LecrisUT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

typo in set_target_properties() in /lib/dpx/CMakeLists.txt

2 participants

@michaeldsmith @LecrisUT