Skip to content

change SOVERSION to use MAJOR.MINOR format instead of MAJOR.MINOR.PATCH #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

change SOVERSION to use MAJOR.MINOR format instead of MAJOR.MINOR.PATCH #186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc770c8
change SOVERSION to use MAJOR.MINOR format instead of MAJOR.MINOR.PAT…
michaeldsmith Jul 27, 2025
10a6a1a
revert changes to CMakeLists.txt
michaeldsmith Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
cmake_minimum_required(VERSION 3.12)
project(CTL VERSION 1.5.3)

set(CTL_VERSION_MAJOR 1)
set(CTL_VERSION_MINOR 5)
set(CTL_VERSION_PATCH 3)
set(CTL_VERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}.${CTL_VERSION_PATCH}")
project(CTL VERSION ${CTL_VERSION})
Copy link

@LecrisUT LecrisUT Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this part. The CTL_VERSION_* are automatically created

include(GNUInstallDirs)

set(CMAKE_CXX_STANDARD 11)
Expand Down
4 changes: 2 additions & 2 deletions lib/IlmCtl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ target_link_libraries (IlmCtl

set_target_properties(IlmCtl
PROPERTIES
VERSION ${CTL_VERSION}
SOVERSION ${CTL_VERSION}
VERSION "${CTL_VERSION}"
SOVERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}"
)

install( FILES
Expand Down
4 changes: 2 additions & 2 deletions lib/IlmCtlMath/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ target_link_libraries (IlmCtlMath

set_target_properties(IlmCtlMath
PROPERTIES
VERSION ${CTL_VERSION}
SOVERSION ${CTL_VERSION}
VERSION "${CTL_VERSION}"
SOVERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}"
)

install(FILES
Expand Down
4 changes: 2 additions & 2 deletions lib/IlmCtlSimd/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ target_link_libraries(IlmCtlSimd

set_target_properties(IlmCtlSimd
PROPERTIES
VERSION ${CTL_VERSION}
SOVERSION ${CTL_VERSION}
VERSION "${CTL_VERSION}"
SOVERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}"
)

install(FILES CtlSimdInterpreter.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/CTL)
Expand Down
6 changes: 3 additions & 3 deletions lib/IlmImfCtl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ target_link_libraries (IlmImfCtl
)

set_target_properties(IlmImfCtl
PROPERTIES
VERSION ${CTL_VERSION}
SOVERSION ${CTL_VERSION}
PROPERTIES
VERSION "${CTL_VERSION}"
SOVERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}"
)

install(FILES
Expand Down
4 changes: 2 additions & 2 deletions lib/dpx/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ target_link_libraries(ctldpx

set_target_properties(ctldpx
PROPERTIES
VERSION ${CTL_VERSION}
SOVERSION ${CTL_VERSION}
VERSION "${CTL_VERSION}"
SOVERSION "${CTL_VERSION_MAJOR}.${CTL_VERSION_MINOR}"
)
Loading