refac: Tidy up token lookup logic #196
Open
+151
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkram
force-pushed
the
refac/tidy-token-lookup-logic
branch
10 times, most recently
from
5aaf3d2 to
aff93ec
Compare
mattkram
force-pushed
the
refac/tidy-token-lookup-logic
branch
3 times, most recently
from
c53c0e8 to
9f7f907
Compare
mattkram
force-pushed
the
refac/tidy-token-lookup-logic
branch
2 times, most recently
from
06c9ba0 to
a66d62d
Compare
…igured with repo-token as default
mattkram
force-pushed
the
refac/tidy-token-lookup-logic
branch
from
a66d62d to
86379df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted refactor from #193. This PR refactors the token lookup logic with domain-level rules so it is centralized in one location. Additionally, we explicitly distinguish between API keys and repo tokens to make the logic more readable and to make it easier to determine which HTTP header to pass.