-
Notifications
You must be signed in to change notification settings - Fork 3
fix: Differentiate error messages depending on required credential type #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mattkram
wants to merge
29
commits into
refac/tidy-token-lookup-logic
Choose a base branch
from
fix/error-response-handlers
base: refac/tidy-token-lookup-logic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: Differentiate error messages depending on required credential type #208
mattkram
wants to merge
29
commits into
refac/tidy-token-lookup-logic
from
fix/error-response-handlers
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igured with repo-token as default
…sages based on channel
… API key install instructions
a66d62d to
86379df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, our request callbacks that handle 401/403 server errors currently do not differentiate between repo tokens and API keys. This is a problem because the instructions are slightly different for how the user should resolve their issue.
anaconda loginanaconda token installThis will remain this way until we unify on API keys for all repository access.
This PR refactors in addition to #196 such that the credential type required for the channel is available inside the
__call__()method. Then, we can construct a callback hook function closure containing the value, which is retrieved if the callback is invoked.There might be more opportunity to cache or otherwise ensure performance of this hook function.
I've extended the tests to test the error messages for the following matrix of cases: