fix: Differentiate error messages depending on required credential type#208

Draft

mattkram wants to merge 29 commits intorefac/tidy-token-lookup-logicfrom

fix/error-response-handlers

Commits on Dec 19, 2025

refac: Move header logic into helper method
mattkram
committed
refac: Move try/except into helper method
mattkram
committed
refac: Flip conditional so API keys are the standard case
mattkram
committed
tidy: Move method up
mattkram
committed
refac: Begin extracting token lookup logic into helper method
mattkram
committed
refac: Replace is_unified boolean with an enum
mattkram
committed
refac: Update return type to return CredentialType
mattkram
committed
refac: Wrap tokens in AccessCredential as a tagged union
mattkram
committed
tidy: Move defaults above conditional for readability
mattkram
committed
feat: Update default to prefer API keys for channels that aren't configured with repo-token as default
mattkram
committed
tidy: Remove unnecessary default rewrite
mattkram
committed
refac: Extract _load_token_domain method call outside and pass as arguments
mattkram
committed
refac: Re-use parsed URL
mattkram
committed
refac: Use explicit credential type to return string credential
mattkram
committed
tidy: Update comments
mattkram
committed
refac: Pass the credential type out of the build_header function
mattkram
committed
feat: Extend test to assert error message
mattkram
committed
feat: Extend parameters to prepare for implementation
mattkram
committed
refac: Extract channel_name into its own fixture for easier overriding
mattkram
committed
feat: Add test to check that channel name is in the message
mattkram
committed
refac: Convert response handlers into closures to allow different messages based on channel
mattkram
committed
feat: Enhance message being tested
mattkram
committed
feat: Extend the error messages to distinguish between repo token and API key install instructions
mattkram
committed
refac: Integrate response handlers
mattkram
committed
tidy: Cleanup, add comments
mattkram
committed
refac: Split out error message
mattkram
committed

Commits on Dec 20, 2025

refac: Use the request headers directly
mattkram
committed
fix: Static type
mattkram
committed
feat: Add test for missing token message, and fix a bug
mattkram
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Differentiate error messages depending on required credential type#208

fix: Differentiate error messages depending on required credential type#208
mattkram wants to merge 29 commits intorefac/tidy-token-lookup-logicfrom
fix/error-response-handlers

Commits on Dec 19, 2025

refac: Move header logic into helper method

refac: Move try/except into helper method

refac: Flip conditional so API keys are the standard case

tidy: Move method up

refac: Begin extracting token lookup logic into helper method

refac: Replace is_unified boolean with an enum

refac: Update return type to return CredentialType

refac: Wrap tokens in AccessCredential as a tagged union

tidy: Move defaults above conditional for readability

feat: Update default to prefer API keys for channels that aren't configured with repo-token as default

tidy: Remove unnecessary default rewrite

refac: Extract _load_token_domain method call outside and pass as arguments

refac: Re-use parsed URL

refac: Use explicit credential type to return string credential

tidy: Update comments

refac: Pass the credential type out of the build_header function

feat: Extend test to assert error message

feat: Extend parameters to prepare for implementation

refac: Extract channel_name into its own fixture for easier overriding

feat: Add test to check that channel name is in the message

refac: Convert response handlers into closures to allow different messages based on channel

feat: Enhance message being tested

feat: Extend the error messages to distinguish between repo token and API key install instructions

refac: Integrate response handlers

tidy: Cleanup, add comments

refac: Split out error message

Commits on Dec 20, 2025

refac: Use the request headers directly

fix: Static type

feat: Add test for missing token message, and fix a bug