Skip to content

library/spi_engine: fix multi-word transfers for clk_div=0 #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

library/spi_engine: fix multi-word transfers for clk_div=0 #1654

merged 2 commits into from
Apr 9, 2025

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Apr 8, 2025

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

LBFFilho added 2 commits April 8, 2025 09:51
@LBFFilho
library/spi_engine: fix transfer counter condition
3ab4d90 
fix bug where for a clock divider of 0, multi-word transfers
could hang without ever completing

Signed-off-by: Laez Barbosa <[email protected]>
@LBFFilho
docs/regmap: update spi_engine patch version
ed7248d 
Signed-off-by: Laez Barbosa <[email protected]>
ladace
ladace approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@ladace ladace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks found!

@LBFFilho LBFFilho merged commit 4632890 into main Apr 9, 2025
3 of 5 checks passed
@LBFFilho LBFFilho deleted the spi_xfer_count_fix branch April 9, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladace ladace ladace approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@podgori podgori Awaiting requested review from podgori podgori is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LBFFilho @ladace