fix: make GsocProjectWidget and bottom sheet dark-mode friendly#451
Closed
adityashirsatrao007 wants to merge 1 commit into
Closed
Conversation
…lend white background logos
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds dark mode support to the GSoC project widget, adjusting colors for the modal bottom sheet, image container, and project cards based on the current theme brightness.
Changes:
- Use theme-aware colors in the modal bottom sheet and image container, with a
ColorFilteredwrapper for the image in dark mode. - Pass
BuildContextinto_buildProjectCardand derive card/text/title colors from the theme. - Wrap the image container with a
BoxDecoration(rounded corners) instead of a flatcolor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| onPressed: () { | ||
| showModalBottomSheet( | ||
| backgroundColor: Colors.white, | ||
| backgroundColor: isDarkMode ? Colors.grey.shade900 : Colors.white, |
Comment on lines
+128
to
+143
| child: isDarkMode | ||
| ? ColorFiltered( | ||
| colorFilter: ColorFilter.mode( | ||
| Colors.grey.shade800, | ||
| BlendMode.multiply), | ||
| child: Image.network( | ||
| modal.imageUrl, | ||
| width: 80, | ||
| height: 80, | ||
| ), | ||
| ) | ||
| : Image.network( | ||
| modal.imageUrl, | ||
| width: 80, | ||
| height: 80, | ||
| ), |
Comment on lines
+128
to
+132
| child: isDarkMode | ||
| ? ColorFiltered( | ||
| colorFilter: ColorFilter.mode( | ||
| Colors.grey.shade800, | ||
| BlendMode.multiply), |
Comment on lines
+185
to
+187
| final cardColor = isDarkMode ? Colors.grey.shade800 : Colors.grey[100]; | ||
| final textColor = isDarkMode ? Colors.white70 : Colors.grey[700]; | ||
| final titleColor = isDarkMode ? Colors.white : Colors.black; |
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Issue No.
Describe Problem / Root Cause
color: Colors.grey[100]background, which rendered as a bright box in dark mode.Colors.white) and project detail cards (color: Colors.grey[100]) were not dark-theme compatible.Solution proposed
GsocProjectWidget.dartto make the image container's background adaptive (isDarkMode ? Colors.grey.shade800 : Colors.grey[100]).Image.networkin aColorFilteredwithBlendMode.multiplyin dark mode to blend white-background images with the dark container.backgroundColor: isDarkMode ? Colors.grey.shade900 : Colors.white).Additional Information
Screenshots