Skip to content

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 12, 2026

Approach

  • Cherry picked david-allison@e782e4d
  • Fixed conflicts
  • Added with (binding) { blocks to remove verbosity (animation lines became multi-line)

How Has This Been Tested?

Brief test:

Pixel 9 Pro - FAB is still usable

⚠️ I removed the brittle tests, mocking does not seem feasible, and we should extract the logic.

Feel free to block this review on this refactor/reimplementing the tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Jan 12, 2026
94 tasks
@david-allison david-allison force-pushed the vb-DeckPickerFloatingActionMenu branch from df40889 to 6a41c18 Compare January 12, 2026 06:22
Tests were removed as they were brittle

Issue 11116
@david-allison david-allison force-pushed the vb-DeckPickerFloatingActionMenu branch from 6a41c18 to c468ae6 Compare January 12, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant