Skip to content

chore: convert DeckPickerFloatingActionMenu to ViewBinding #20081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-allison wants to merge 2 commits into
base: main
Choose a base branch
from
+192 −299
Open

chore: convert DeckPickerFloatingActionMenu to ViewBinding #20081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8017caa
refactor(deck-picker): FAB: rename 'action' -> 'button'
david-allison Jan 12, 2026
c468ae6
chore: convert DeckPickerFloatingActionMenu to ViewBinding
david-allison Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AnkiDroid/src/androidTest/java/com/ichi2/anki/testutil/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ fun createDeckWithUniqueName(): String {
val testString = System.currentTimeMillis().toString()
val deckName = "TestDeck$testString"
onView(withId(R.id.fab_main)).perform(click())
onView(withId(R.id.add_deck_action)).perform(click())
onView(withId(R.id.add_deck_button)).perform(click())
onView(withId(R.id.dialog_text_input)).perform(typeText(deckName))
onView(withText(R.string.dialog_ok)).perform(click())
return deckName
Expand Down
5 changes: 1 addition & 4 deletions AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,6 @@ open class DeckPicker :
decksLayoutManager = LinearLayoutManager(this)
deckPickerBinding.decks.layoutManager = decksLayoutManager

// Add background to Deckpicker activity
val view = binding.deckpickerXlView ?: binding.rootLayout

deckListAdapter =
DeckAdapter(
this,
Expand Down Expand Up @@ -590,7 +587,7 @@ open class DeckPicker :
}
// Setup the FloatingActionButtons
floatingActionMenu =
DeckPickerFloatingActionMenu(this, view, this).apply {
DeckPickerFloatingActionMenu(this, binding, this).apply {
toggleListener =
FloatingActionBarToggleListener { isOpening ->
closeFloatingActionBarBackPressCallback.isEnabled = isOpening
Expand Down
Loading