fix(accessibility): add contentDescription to Add Deck FAB #20120
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Author
|
@david-allison Thanks for taking a look when you have time. |
Member
|
@Chiraggupta0 no need to ping, thanks for the PR, I'll get around to it when I have time Typically: give people 48 hours to respond, 24 is fine for me |
david-allison
requested changes
Jan 16, 2026
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "java.compile.nullAnalysis.mode": "disabled" | |||
Member
There was a problem hiding this comment.
What does this do? Why was it added?
| android:layout_margin="16dp" | ||
| android:layout_marginBottom="40dp" | ||
| android:src="@drawable/ic_add_white" /> | ||
| android:src="@drawable/ic_add_white" |
Member
There was a problem hiding this comment.
How did you test the before/after? This doesn't appear to be the correct file.
| <string name="app_not_initialized_new">AnkiDroid is not initialized yet. Please open AnkiDroid and try again</string> | ||
|
|
||
| <!-- Deck Creation --> | ||
| <string name="add_deck">Add deck</string> |
Member
There was a problem hiding this comment.
Use TR.actionsAddDeck with a sentence case modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This PR fixes an accessibility issue on the Home screen when the collection is empty.
The Add Deck FloatingActionButton did not have a content description, causing TalkBack and other screen readers to announce it as “Unlabelled”. This makes it difficult for users relying on assistive technologies to understand the purpose of the control.
Fixes
Approach
Adds a localized contentDescription to the Add Deck FAB
Introduces a new string resource (add_deck) for proper accessibility support
No visual or behavioral changes for sighted users
How Has This Been Tested?
Ran the app locally on an emulator
Verified the layout change
Confirmed using Accessibility Scanner that the FAB is now properly labeled
Test Video
ankidroid.issue.20110.mp4
Checklist
Please, go through these checks before submitting the PR.