Skip to content

fix(accessibility): add contentDescription to Add Deck FAB #20120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chiraggupta0 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(accessibility): add contentDescription to Add Deck FAB #20120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"java.compile.nullAnalysis.mode": "disabled"
Copy link
Member

@david-allison david-allison Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Why was it added?

}
4 changes: 3 additions & 1 deletion AnkiDroid/src/main/res/layout/widget_deck_picker_config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@
android:layout_alignParentEnd="true"
android:layout_margin="16dp"
android:layout_marginBottom="40dp"
android:src="@drawable/ic_add_white" />
android:src="@drawable/ic_add_white"
Copy link
Member

@david-allison david-allison Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test the before/after? This doesn't appear to be the correct file.

android:contentDescription="@string/add_deck" />

</RelativeLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
2 changes: 2 additions & 0 deletions AnkiDroid/src/main/res/values/02-strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@
<string name="app_not_initialized_new">AnkiDroid is not initialized yet. Please open AnkiDroid and try again</string>

<!-- Deck Creation -->
<string name="add_deck">Add deck</string>
Copy link
Member

@david-allison david-allison Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TR.actionsAddDeck with a sentence case modifier

https://github.com/ankidroid/Anki-Android/blob/043399abd818365e54e2ba9530a1f5ea119d9aca/AnkiDroid/src/main/res/values/sentence-case.xml


<string name="deck_created">Deck created</string>
<string name="deck_renamed">Deck renamed</string>

Expand Down