-
Notifications
You must be signed in to change notification settings - Fork 1.7k
lvm_pv: new module for LVM Physical Volumes #10070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Two first quick suggestions:
- Please take a look at https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins in case you didn't.
- How about naming the module
lvm_pv
?
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @klention
Thanks for your contribution. I left some initial comments.
You might want to consider using CmdRunner
. See https://docs.ansible.com/ansible/latest/collections/community/general/docsite/guide_cmdrunner.html for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of (minor) suggestions, other than that LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to add tests, otherwise this won't get merged. (See https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins.)
ping @klention |
09be8cd
to
1effe6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @klention Thanks for the updates, it is looking very good now.
I just spotted a couple of minor things, but other than that it is good to go.
Hi @russoz, Thank you for your guidance and support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your work on the module!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better adjust the YAML list indentation to the style all other modules and plugins use:
* Added LVM Physical Volume module * Fixed CI checks * python 2.7 compatibility * Fixed another fprint line not compatible with python 2.x * Applied cosmetic changes * Removed msg from RETURN section * Updated the 'absent state' block logic * Added integration tests * Updated logic for creating loop devices on Alpine Linux * Updated loop device path * Minor, cosmetic changes * Adjust indentation. --------- Co-authored-by: Felix Fontein <[email protected]>
SUMMARY
This pull request introduces a new
lvm_pv
module for managing LVM Physical Volumes. The module provides comprehensive functionality for:Key features:
pvcreate
,pvremove
,pvresize
)The module fills a gap in Ansible's storage management capabilities, complementing the existing
lvg
andlvol
modules.ISSUE TYPE
COMPONENT NAME
lvm_pv
ADDITIONAL INFORMATION
Example usage: