added better idempotency for zabbix-service #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatted service_ids as list
- from "extend" to ["serviceid"] this is for the comparison between the existing child/parent service and the passed child/parent service - added sorting by serviceid
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
- Coverage 79.07% 78.74% -0.33%
==========================================
Files 48 48
Lines 6093 6145 +52
Branches 1573 1600 +27
==========================================
+ Hits 4818 4839 +21
- Misses 784 796 +12
- Partials 491 510 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, |
pyrodie18
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replacement for #1412
ISSUE TYPE
COMPONENT NAME
zabbix_service module