added better idempotency for zabbix-service #1412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljvdhooft |
…x into zabbix-service
formatted service_ids as list
- from "extend" to ["serviceid"] this is for the comparison between the existing child/parent service and the passed child/parent service - added sorting by serviceid
|
hi, please check again. Tests passed locally |
BGmot
reviewed
Apr 27, 2025
Comment on lines
+9
to
+11
| branches: | ||
| - dev | ||
| - main |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 79.05% 78.71% -0.34%
==========================================
Files 47 47
Lines 5958 6010 +52
Branches 1539 1566 +27
==========================================
+ Hits 4710 4731 +21
- Misses 768 782 +14
- Partials 480 497 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 14, 2025
Open
|
Retired in favour of #1538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds better idempotency that checks every parameter for change and updates only the changed ones. Also fixes a small bug that requires the "propagation_value" if "propagation_rule" is not set, because "propagation_rule" had a default value. This has been removed so that if both parameters are not used an error won't raise.
ISSUE TYPE