Skip to content

Adding new pre-commit config#503

Merged
oraNod merged 6 commits intoansible-community:mainfrom
x1101:f_pre-commit
Jan 29, 2026
Merged

Adding new pre-commit config#503
oraNod merged 6 commits intoansible-community:mainfrom
x1101:f_pre-commit

Conversation

@x1101
Copy link
Contributor

@x1101 x1101 commented Dec 19, 2025

Adds .pre-commit-config.yaml, but doesn't add pre-commit to requirements at this time.

This means it can be used, but is not currently installed/required by default.

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oraNod oraNod mentioned this pull request Jan 8, 2026
@x1101
Copy link
Contributor Author

x1101 commented Jan 12, 2026

Doing a rebase to pull in the work from #507 and #503

@oraNod oraNod mentioned this pull request Jan 28, 2026
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @x1101 Let's merge #511 and then I think we're ready. Do you want to do a follow on to add pre-commit to requirements and add a ci check? Or do you want to do that as part of this PR? I'm leaning more towards the latter but I'll leave it up to you.

@x1101
Copy link
Contributor Author

x1101 commented Jan 28, 2026

Thanks for this @x1101 Let's merge #511 and then I think we're ready. Do you want to do a follow on to add pre-commit to requirements and add a ci check? Or do you want to do that as part of this PR? I'm leaning more towards the latter but I'll leave it up to you.

I'd also agree that it should be a distinct PR for that, in the (near) future.

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @x1101

@oraNod oraNod merged commit 9e72c52 into ansible-community:main Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments