Skip to content

fix end of files#511

Merged
oraNod merged 1 commit intoansible-community:mainfrom
oraNod:fix-end-files
Jan 29, 2026
Merged

fix end of files#511
oraNod merged 1 commit intoansible-community:mainfrom
oraNod:fix-end-files

Conversation

@oraNod
Copy link
Contributor

@oraNod oraNod commented Jan 28, 2026

Relates to #503 and fixes two end of file issues that would fail pre-commit checks.

@oraNod
Copy link
Contributor Author

oraNod commented Jan 28, 2026

I found this change a little confusing so I had a look. Figured I'd share.

Before the change I see this:

cat -A dev.conf.py 
from conf import *$
URL_TYPE = 'rel_path'$
$
# Override to display the global banner$
# GLOBAL_CONTEXT.update({ "BANNER": True, })$
$

After the change I see this:

cat -A dev.conf.py 
from conf import *$
URL_TYPE = 'rel_path'$
$
# Override to display the global banner$
# GLOBAL_CONTEXT.update({ "BANNER": True, })$

So before the change there is an extra dollar sign $. Taking a look at other files in the same way shows that the changes make these two files consistent. For example:

cat -A conf.py

....
# Final command is: SASS_COMPILER SASS_OPTIONS file.s(a|c)ss$
SASS_OPTIONS = []$
$
# Create 404 error page$
CREATE_HTTP_ERROR_PAGES = [404]$
cat -A robots.txt 
User-agent: *$
Disallow: /projects/ansible/devel/$
Disallow: /projects/ansible/12/$
Disallow: /projects/ansible/11/$
Disallow: /projects/ansible/10/$
Disallow: /projects/ansible/9/$
Disallow: /projects/ansible/8/$
Disallow: /projects/ansible/7/$
Disallow: /projects/ansible/6/$
Disallow: /projects/ansible/5/$
Disallow: /projects/ansible/4/$
Disallow: /projects/ansible/3/$
Disallow: /projects/ansible/2.10/$
Disallow: /projects/ansible/2.9/$
Disallow: /projects/ansible/2.8/$
Disallow: /projects/ansible/2.7/$
Disallow: /projects/ansible/2.6/$
Disallow: /projects/ansible/2.5/$
Disallow: /projects/ansible/2.4/$
Disallow: /projects/ansible/2.3/$
Disallow: /projects/ansible/2.8-archive/$
Disallow: /projects/ansible/2.7-archive/$
Disallow: /projects/ansible/2.6-archive/$
Disallow: /projects/ansible/2.5-archive/$
Disallow: /projects/ansible/2.4-archive/$
Disallow: /projects/ansible/2.3-archive/$
$
Sitemap: https://docs.ansible.com/ansible-sitemap.xml$

@oraNod oraNod merged commit 8084a15 into ansible-community:main Jan 29, 2026
5 checks passed
@oraNod
Copy link
Contributor Author

oraNod commented Jan 29, 2026

Thanks for the review and approval @gundalow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments