Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-19344: add data types for errors in catch block #786

Merged
merged 2 commits into from
Jan 18, 2024
Merged

AAP-19344: add data types for errors in catch block #786

merged 2 commits into from
Jan 18, 2024

Conversation

hasys
Copy link
Contributor

@hasys hasys commented Jan 17, 2024

Jira Issue: <https://issues.redhat.com/browse/AAP-19344

Description

First part of the solution, covered all but others section from the Jira issue description. Others part requires investigations of all possible exceptions JSON provided by the wisdom service.

Testing

Steps to test

  1. Pull down the PR
  2. Run unit tests.

Scenarios tested

Described above.

Production deployment

  • This code change is ready for production on its own

manstis
manstis previously approved these changes Jan 17, 2024
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank-you.

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hasys hasys merged commit c798c22 into main Jan 18, 2024
5 checks passed
@hasys hasys deleted the ts_types branch January 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants