feat(platform): hide subscription banners for non-admin users

[ffirg]

Summary

Hide the "out of compliance" banner for non-admin users.

Non-admin users cannot act on subscription compliance issues, so displaying the banner to them:

• Causes confusion ("should I stop using the platform?")
• Creates unnecessary support burden

This change hides all subscription-related banners (compliance, grace period, expiry warnings) for non-superuser accounts.

Risk Analysis - REQUIRED

• High
• Medium
• Low

Justification:

• Change is isolated to banner visibility logic only
• No API changes, no backend changes
• Uses existing usePlatformActiveUser hook (already in use elsewhere)
• All existing tests pass; 3 new tests added
• Easy to revert if needed

Changes Made

• platform/main/PlatformApp.tsx: Add is_superuser check to subscriptionBanner useMemo
• platform/main/PlatformApp.test.tsx: Add 3 new test cases covering admin/non-admin scenarios

Implementation Details

Uses existing pattern from SubscriptionDetails.tsx:

const { activePlatformUser } = usePlatformActiveUser();
// ...
if (!activePlatformUser?.is_superuser) return null;

Test Plan

• All 14 existing tests pass
• New tests verify:
  • Non-admin users do NOT see compliance banners
  • Admin users DO see compliance banners
  • Non-admin users do NOT see subscription expiry banners
• TypeScript compilation passes
• ESLint passes

Manual Testing Steps

1. Log in as a non-superuser account
2. Ensure subscription is out of compliance (or will expire soon)
3. Verify: No red/yellow subscription banner appears
4. Log in as superuser account
5. Verify: Subscription banner appears as expected

Screenshots

N/A - Banner visibility change only

---

🤖 Generated with Claude Code

[marshmalien]

/run-playwright

[marshmalien]

Pulled down locally and it looked good. Before we merge, since this is our upstream repo, could we remove all references to internal jira tickets:

• PR title and description
• Code comments in PlatformApp.tsx
• Test names/comments in PlatformApp.test.tsx

[aap-pde-ci-bot]

Currents dashboard

[ffirg]

CI Failure Analysis

The Vitest (framework) failure is unrelated to this PR's changes. It's a pre-existing flaky test in the framework package:

Vitest caught 1 unhandled error during the test run.

ReferenceError: window is not defined
 ❯ PageToolbar/PageToolbarFilter.tsx:282:7

This is an async cleanup issue where React tries to update state after the test environment is torn down. This PR only modifies files in platform/main/ — no framework code was touched.

Vitest (platform) passed all tests including the 3 new tests for this feature.

Could you please re-run the failed check? These types of race conditions often pass on retry.

---

Re: SonarQube failure — this is expected for fork PRs (no access to repo secrets). Happy to discuss alternatives if needed.

[ffirg]

Closing in favor of #3148 (pushed directly to repo to enable SonarQube checks)